[addons] improve downgrading/version changing support #8038
Conversation
tamland
added
Type: Feature
tamland
force-pushed
the
addon_installer_multiversion
branch
from
aa48df7
to
bd46b0b
Compare
| if (!m_localAddon) | ||
| return; | ||
|
|
||
| auto* dialog = static_cast<CGUIDialogSelect*>(g_windowManager.GetWindow(WINDOW_DIALOG_SELECT)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tamland
force-pushed
the
addon_installer_multiversion
branch
from
bd46b0b
to
8fdd693
Compare
|
You might want to remove the |
must be unloaded first (cpluff wont downgrade automatically)
…versions to allow updating, downgrading and changing which repository to install from
tamland
force-pushed
the
addon_installer_multiversion
branch
from
8fdd693
to
92b3f9d
Compare
|
jenkins build this please |
|
@mkortstiege good to go? |
|
Looks good. jenkins build and merge. |
|
I wonder why the "Upgrade" button is enabled if i just installed the latest version from repo? |
|
It doesn't strictly do "upgrading" any more but opens a window where you can manage/see all available versions (i plan to put rollback in there as well). It doesn't make any sense to disable that in some special cases. It will show an empty list if it's in no repos, it shows one item highlighted you have the latest version. The reason it reinstalls is because we don't track what is installed and where they come from, so there's no way to know it's the same one; other than comparing the version. |
This adds various client changes needed to support having multiple versions in the same repository and for installing specific versions from specific repositories.
On the gui side it changes the 'update' functionality in the info dialog to show a list of available versions and repositories which can be installed. Note that requires server side support. Currently there is only one version kept in the official repository.