[music] Removed refresh on artist/album info

[evilhamster]

There is a problem (thread about it: http://forum.kodi.tv/showthread.php?tid=238853) where when you check for artist/album information and the scraper can't find any information it will get stuck in a loop where you get to reenter the name of the album and/or artist and unless you change the album and/or artist to something the scraper can find it will never show the information page for the album or artist. Since you need to be able to get to the information page to be able to select "get thumb", you are unable to set (or change in the case one was found locally during scanning) for an item that the scraper can't find.

This change does the following change, it disables refresh when showing the information page (for an artist and/or album that hasn't been scraped). The advantage with doing it like this is that just checking the information on an artist and/or album wont change any information without a direct action from the user.

@razzeee @DaveTBlake @zag2me
What do you think?

[razzeee]

+1
Nothing wrong with that.

[zag2me]

Perfect! thank you, this bug has been around for years!

[akva2]

In fact i fixed it in 2007 but it was brought back as peeps (or vampires - not sure if elan qualifies as a peep) insisted on lookups for files/folders. So 8 years.

[evilhamster]

A golden oldie then :)

Made a small change to the commit, in the original I made it did "if (refresh && !m_musicdatabase.HasArtistBeenScraped(params.GetArtistId()))" but since the refresh was set to true in the same place as ClearArtistLastScrapedTime was executed it really didn't make sense. I kept the ClearArtistLastScrapedTime since I think there could be other places in the code that depends on lastscraped beeing null (what the clear function does), but I'm not sure. does anyone know?

If it's a requirement that it should try and scrape material that hasn't been scrape, let me know and I'll try to adapt this pr so that it at only tries to scrape once on checking information to avoid the loops. But from a ui perspective I think I prefer it like this.

[DaveTBlake]

Will be good to see this bug fixed, was intending to look at it myself but you beat me to it! I would like to check things through on my dev system when I get back to it at the weekend (busy with family stuff at the moment).

My view of UI is that initiating scraping should be a separate action from looking at info. This would require a context menu change, but the hidden automatic scraping is not something all users actually want, especially if the scraper gets it wrong.

[DaveTBlake]

@evilhamster good stuff!
Finally this checked over. I was looking to fix this in a different place, but this fixes the bug and removes the inadvertent scraping as well.

Can we get this built and merged please.

[razzeee]

jenkins build this please

[MartijnKaijser]

Ignore osx32 build error

[mkortstiege]

jenkins build this please.

[stefansaraev]

ignore Llinux64 build error