[guiinfo] (VIDEOPLAYER|LISTITEM)_AUDIO_CHANNELS return empty string for 0 channels, not '0'. #8059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
|
Good idea, don't know why skins even have a 0.0 icon at all since obviously there's no such thing as 0-channel audio. |
|
@ronie can we drop that icon from Confluence now that it's never used anymore? |
|
please ping someone else too, @mkortstiege +1 because no audio don't need an icon. |
|
No objections. Please add the confluence commit as a separate one. |
…or 0 channels, not '0'.
ksooo
force-pushed
the
guiinfo-audio-channels-exclude-zero
branch
from
d2b63a0
to
24201b4
Compare
ksooo
force-pushed
the
guiinfo-audio-channels-exclude-zero
branch
from
24201b4
to
ed7fcac
Compare
|
Icon removed in separate commit, as requested. jenkins build this please |
|
All(?) binary addons failed to build an Linux. This is not related to this PR. |
ksooo
added a commit
that referenced
this pull request
Sep 16, 2015
[guiinfo] (VIDEOPLAYER|LISTITEM)_AUDIO_CHANNELS return empty string for 0 channels, not '0'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Confluence, when switching PVR channels and OSD is displayed at that time
That [0.0] badge in between is ugly. ;-)
Reason is that GUIInfomanager returns "0" if no sound is avalaible and the skin maps that to 0.0 badge.
@xhaggi mind taking a look