Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appmessenger] Fix broken python addons after #7800 #8065

Merged
merged 1 commit into from
Sep 17, 2015

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Sep 16, 2015

Revert this message sorting as it broke some stuff and was a dumb thing to do
thanks @anaconda for finding this.

@Paxxi Paxxi added the Type: Fix non-breaking change which fixes an issue label Sep 16, 2015
@Paxxi
Copy link
Member Author

Paxxi commented Sep 16, 2015

jenkins build and merge this please

@MartijnKaijser
Copy link
Member

jenkins build this please

@MilhouseVH
Copy link
Contributor

Just testing this PR and it's not working as expected - same behaviour as without, no dialog from trakt. The original fix in #8063 did/does work.

Edit: Damn, might have a typo in my build - that's what happens when building after a night out...

@MilhouseVH
Copy link
Contributor

Sorry for the false alarm, trakt is working correctly with this PR.

MartijnKaijser added a commit that referenced this pull request Sep 17, 2015
[appmessenger] Fix broken python addons after #7800
@MartijnKaijser MartijnKaijser merged commit b9d1772 into xbmc:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants