Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvdplayer: fix non DVB subs after 5c0d694fa769f311bc5e14dec04c260267a… #8137

Merged
merged 1 commit into from
Sep 30, 2015
Merged

dvdplayer: fix non DVB subs after 5c0d694fa769f311bc5e14dec04c260267a… #8137

merged 1 commit into from
Sep 30, 2015

Conversation

FernetMenta
Copy link
Contributor

see title

@ace20022 @jspdr does this fix the issue

@Jalle19 could you test if 1080i still works with this patch?

@stefansaraev
Copy link
Contributor

jenkins build this please

@stefansaraev stefansaraev added Type: Fix non-breaking change which fixes an issue Backport: Needed labels Sep 28, 2015
@Jalle19
Copy link
Member

Jalle19 commented Sep 28, 2015

@stefansaraev did you test this? I haven't had time yet.

@stefansaraev
Copy link
Contributor

@Jalle19 I did. dvb and non dvb subtitles are good here. I didnt have any issues after 5c0d694 btw.

@jpsdr
Copy link
Contributor

jpsdr commented Sep 29, 2015

Is there any build i can test with ?

@ace20022
Copy link
Member

@jpsdr http://mirrors.xbmc.org/test-builds/win32/KodiSetup-20150926-6597f98-subfix.exe

@jpsdr
Copy link
Contributor

jpsdr commented Sep 30, 2015

Tested, sub issue is fixed. Check also all my no-regression test files, they all pass Ok.

@stefansaraev stefansaraev mentioned this pull request Sep 30, 2015
Merged
@FernetMenta
Copy link
Contributor Author

thanks

FernetMenta added a commit that referenced this pull request Sep 30, 2015
@FernetMenta
Merge pull request #8137 from FernetMenta/subfix
92418f3 
dvdplayer: fix non DVB subs after 5c0d694…
@FernetMenta FernetMenta merged commit 92418f3 into xbmc:master Sep 30, 2015
@FernetMenta FernetMenta deleted the subfix branch September 30, 2015 14:50
@MartijnKaijser MartijnKaijser added this to the Jarvis 16.0-alpha3 milestone Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Jarvis 16.0-alpha3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FernetMenta @stefansaraev @Jalle19 @jpsdr @ace20022 @MartijnKaijser