Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] Fix errors after switching from using backend channel numbers to using kodi channel numbers and vica versa #8204

Merged
merged 1 commit into from Oct 13, 2015

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 11, 2015

When switching between "use backend channel numbers" and "use kodi backend numbers" and not restarting kodi after that, one might have ended up with switching to the wrong channel or to no channel at all for certain channels, if the backend version numbers have "gaps". This PR fixes this.

@negge mind taking a look (We talked about this bug at DevCon).

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v16 Jarvis labels Oct 11, 2015
@Jalle19
Copy link
Member

Jalle19 commented Oct 12, 2015

This fix would be valid for Isengard as well since the regression was introduced some time after Helix was released.

@ksooo
Copy link
Member Author

ksooo commented Oct 13, 2015

@Jalle19 imo this is just an edge case not worth backporting. Fine with that?

@Jalle19
Copy link
Member

Jalle19 commented Oct 13, 2015

Okay, fine by me.

@ksooo
Copy link
Member Author

ksooo commented Oct 13, 2015

jenkins build this please

ksooo added a commit that referenced this pull request Oct 13, 2015
[pvr] Fix errors after switching from using backend channel numbers to using kodi channel numbers and vica versa
@ksooo ksooo merged commit 8cb3f36 into xbmc:master Oct 13, 2015
@ksooo ksooo deleted the fix-channelnumber-switching branch October 13, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants