Minor cleanup to match naming convention in video database #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Paxxi your button ;) |
mkortstiege
added
the
Type: Cleanup
|
This export still has some issues. The separate files export doesn't seem to work correctly to the folder you choose, I was looking at it a bit more |
|
This will break as singlefiles means one file per thing and singlefile means everything in one file so the checks need to be reversed. E.g if(singlefiles) becomes if(!singlefile) and so on, if you can update it we can merge it |
|
You are completely right, I will make the changes |
To complement [xbmc][library] Fix export library #8152
|
Updated @Paxxi feel free to let me know if anything is still broken. |
|
Looks good to me. @Paxxi please merge when you're happy with it. |
|
Haven't had time to test it but changes look good |
Paxxi
added a commit
that referenced
this pull request
Oct 18, 2015
Minor cleanup to match naming convention in video database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complement [xbmc][library] Fix export library #8152