New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pvr] fix playback of recordings when an exact duplicate exists. #8219
Conversation
This happens if one for some reason records a show twice, stopping in between (which creates two separate recordings)
jenkins build this please |
Fixes kodi-pvr/pvr.hts#69 and http://forum.kodi.tv/showthread.php?tid=232815 by the way |
This one bugged me for a long time. Thx for the fix. |
[pvr] fix playback of recordings when an exact duplicate exists.
Per my comment in #8220, do we want to revert this since it breaks all resume points/watched statuses for existing recordings (since the file item path has changed)? |
I suggest to revert and to come up with a proper fix. |
This is a proper fix but we need to somehow migrate the "bookmarks" to use the new path. I'm fine with reverting for now though. |
I want to release 15.2 tomorrow. Make reverting doesn't make it worse |
@MartijnKaijser we're discussing reverting in master, Isengard was never touched so go ahead and make a release if you'd like. |
This happens if one for some reason records a show twice, stopping
in between (which creates two separate recordings).
@ksooo should we backport this? The issue is relatively rare but it inevitable prevents playback of any duplicate recordings.