Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] fix playback of recordings when an exact duplicate exists. #8219

Merged
merged 1 commit into from Oct 14, 2015

Conversation

Jalle19
Copy link
Member

@Jalle19 Jalle19 commented Oct 14, 2015

This happens if one for some reason records a show twice, stopping
in between (which creates two separate recordings).

@ksooo should we backport this? The issue is relatively rare but it inevitable prevents playback of any duplicate recordings.

This happens if one for some reason records a show twice, stopping
in between (which creates two separate recordings)
@Jalle19 Jalle19 added Type: Fix non-breaking change which fixes an issue Component: PVR labels Oct 14, 2015
@Jalle19
Copy link
Member Author

Jalle19 commented Oct 14, 2015

jenkins build this please

@Jalle19
Copy link
Member Author

Jalle19 commented Oct 14, 2015

@ksooo
Copy link
Member

ksooo commented Oct 14, 2015

This one bugged me for a long time. Thx for the fix.
Obviously a nobrainer. So, code change looks good.
I think it's worth backporting.

Jalle19 added a commit that referenced this pull request Oct 14, 2015
[pvr] fix playback of recordings when an exact duplicate exists.
@Jalle19 Jalle19 merged commit fc1e1d1 into xbmc:master Oct 14, 2015
@Jalle19
Copy link
Member Author

Jalle19 commented Oct 18, 2015

Per my comment in #8220, do we want to revert this since it breaks all resume points/watched statuses for existing recordings (since the file item path has changed)?

@ksooo
Copy link
Member

ksooo commented Oct 18, 2015

I suggest to revert and to come up with a proper fix.

@Jalle19
Copy link
Member Author

Jalle19 commented Oct 18, 2015

This is a proper fix but we need to somehow migrate the "bookmarks" to use the new path. I'm fine with reverting for now though.

@MartijnKaijser
Copy link
Member

I want to release 15.2 tomorrow. Make reverting doesn't make it worse

@Jalle19
Copy link
Member Author

Jalle19 commented Oct 18, 2015

@MartijnKaijser we're discussing reverting in master, Isengard was never touched so go ahead and make a release if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v16 Jarvis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants