Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests on linux/os-x #8317

Merged
merged 1 commit into from Oct 31, 2015
Merged

Fix unit tests on linux/os-x #8317

merged 1 commit into from Oct 31, 2015

Conversation

pokowaka
Copy link
Contributor

  • Older tag lib libraries handle tag types differently
  • Added missing comment setter for ID3v2

@pokowaka
Fix unit tests on linux/os-x
adba28a 
- Older tag lib libraries handle tag types differently
- Added missing comment setter for ID3v2
@razzeee razzeee added Platform: Linux Platform: macOS Type: Fix non-breaking change which fixes an issue labels Oct 29, 2015
@razzeee
Copy link
Member

razzeee commented Oct 30, 2015

Builded the tests: http://jenkins.kodi.tv/view/Helpers/job/TestMulti-All/lastFailedBuild/
OSX-64 error seems to be unrelated. Fixes the previous problems, thank you!

One thing that I found in the log, which looks a bit weird and is totally unrelated to this change:

[----------] 3 tests from TestTagParser/4, where TypeParam = TagLib::Ogg::XiphComment
[ RUN      ] TestTagParser/4.ParsesBasicTag
[       OK ] TestTagParser/4.ParsesBasicTag (1 ms)
[ RUN      ] TestTagParser/4.HandleNullTag
[       OK ] TestTagParser/4.HandleNullTag (0 ms)
[ RUN      ] TestTagParser/4.FooProperties
TagLib: A picture block must contain at least 5 bytes.
TagLib: A picture block must contain at least 5 bytes.
[       OK ] TestTagParser/4.FooProperties (1 ms)
[----------] 3 tests from TestTagParser/4 (2 ms total)

@razzeee razzeee added this to the Jarvis 16.0-alpha4 milestone Oct 30, 2015
@MartijnKaijser
Copy link
Member

jenkins build and merge

jenkins4kodi added a commit that referenced this pull request Oct 31, 2015
@jenkins4kodi
Merge pull request #8317 from pokowaka/fix_unit_test
17c1b4f
@jenkins4kodi jenkins4kodi merged commit 17c1b4f into xbmc:master Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: Linux Platform: macOS Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Jarvis 16.0-alpha4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pokowaka @razzeee @MartijnKaijser @jenkins4kodi