[iimage] Prevent possible access violations, especially for gifs. #8348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible access violation.
…method Decode(...).
…e access violation.
…cally possible access violation.
…ally possible access violation.
|
Thanks very much. the cximage and the image fixes look good to me. |
|
jenkins build this please |
ace20022
added a commit
that referenced
this pull request
Nov 5, 2015
[iimage] Prevent possible access violations, especially for gifs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fritsch fyi
The cximage and jpegio commits are debatable. There seems to be a convention that the LoadIImage(...) implementation already scales the image, however the pitch and the height of a texture could be changed afterwards under rare circumstances.