Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iimage] Prevent possible access violations, especially for gifs. #8348

Merged
merged 7 commits into from Nov 5, 2015

Conversation

Projects
None yet
3 participants
@ace20022
Copy link
Member

ace20022 commented Nov 4, 2015

@fritsch fyi
The cximage and jpegio commits are debatable. There seems to be a convention that the LoadIImage(...) implementation already scales the image, however the pitch and the height of a texture could be changed afterwards under rare circumstances.

@fritsch

This comment has been minimized.

Copy link
Member

fritsch commented Nov 4, 2015

Thanks very much. the cximage and the image fixes look good to me.

@ace20022

This comment has been minimized.

Copy link
Member Author

ace20022 commented Nov 5, 2015

jenkins build this please

ace20022 added a commit that referenced this pull request Nov 5, 2015

Merge pull request #8348 from ace20022/gif_fixes_16
[iimage] Prevent possible access violations, especially for gifs.

@ace20022 ace20022 merged commit 1a72fdd into xbmc:master Nov 5, 2015

1 check passed

default Merged build finished.
Details

@ace20022 ace20022 deleted the ace20022:gif_fixes_16 branch Nov 5, 2015

@hudokkow hudokkow added this to the Jarvis 16.0-beta1 milestone Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.