[PVR] Timer update: Fix handling of timers with 'start at any time' #8452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
|
Is |
|
"Empty", not current. That's of course essential. Otherwise the fix won't work. :-) |
|
@Jalle19 any objections? |
|
jenkins build this please |
|
Merging now, want it in beta 3 to avoid screaming users. ;-) |
ksooo
added a commit
that referenced
this pull request
Nov 29, 2015
[PVR] Timer update: Fix handling of timers with 'start at any time'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced with 5d8f88c
For timers with start time set to "any time", the startTime value must not be used to organize internal timer data structures as this field has no defined value for those timers.
Result is (for instance with pvr.hts and at least one repeating timer activated which has start and end time set to "any time") reorganizing kodi internal timer data structures every one second and notifying observers, e.g. timer and recording window about "timer reset" changes.
=> https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/timers/PVRTimers.cpp#L255
Those windows will update itself (redraw item list etc.) upon receive of this notification which is exposed to the end user as "wildly" jumping item selection etc. in timer and recordings pvr window, at worst every 3 second.
https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/windows/GUIWindowPVRRecordings.cpp#L315
@Jalle19 Good to go? This could be done nicer, yeah, but I want to keep changes minimalistic. I promise to come up with a proper refactoring for K*****. ;-)