-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python local weekday name #8478
Conversation
@tamland ping |
Looks sane to me. Perhaps @Montellese wants to have a look as well? |
@Montellese can you give your blessings? |
I don't have much experience with |
jenkins build this please |
I don't know why on some systems we aren't using |
Build is already gone :/ |
xbmc/LangInfo.cpp
Outdated
@@ -300,6 +302,7 @@ void CLangInfo::CRegion::SetGlobalLocale() | |||
strLocale = lcl.name(); | |||
current_locale = current_locale.combine< std::collate<wchar_t> >(lcl); | |||
current_locale = current_locale.combine< std::ctype<wchar_t> >(lcl); | |||
current_locale = current_locale.combine< std::time<wchar_t> >(lcl); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Now |
@tamland & @Montellese please check again jenkins build this please |
ping |
I don't know too much about locale but setlocale isn't used in windows because it causes crashes if executed in multiple threads: |
@phate89 tested on windows and Kodi isn't crashing. If you want I can also exclude |
It doesn't always crash but it crashes when executed from multiple threads.. Or at least is what I understood from that thread. For this reason we always fidef _wsetlocale in windows |
I've excluded windows from the |
Haven't touched setlocale in a while but I think it should be safe on windows now that we have unified our crt usage. |
@Paxxi I can drop
|
You can leave it as is, calling the w methods are preferred as the normal methods are just wrappers for them anyway |
jenkins build this please |
Some strange error for Android-X86 occurred. |
jenkins build this please |
any objections? |
If you want to get the weekdays locale name in a python script it now display it in the right language. Previously it was always english.