Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile errors in RendererOMX.cpp #8598

Merged
merged 2 commits into from Dec 17, 2015
Merged

Conversation

zpon
Copy link
Contributor

@zpon zpon commented Dec 15, 2015

I found a few compile-time errors in RendererOMX.cpp (see 9435210), which I have tried to fix.

I'm not too sure about the changes, and hope somebody can help me review them.
The bool CRendererOMX::Supports(ESCALINGMETHOD mode)-method was missing, so I added it with return false;, I have no idea whether this is correct.

@@ -27,6 +27,7 @@
#include "utils/GLUtils.h"
#include "settings/MediaSettings.h"
#include "windowing/WindowingFactory.h"
#include "DVDCodecs/Video/DVDVideoCodecIMX.h"

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@zpon
Copy link
Contributor Author

zpon commented Dec 17, 2015

I have changed the pull request to accommodate the requested changes. Please let me know if you see any other problems.

@FernetMenta
Copy link
Contributor

thanks. does it work again?

@zpon
Copy link
Contributor Author

zpon commented Dec 17, 2015

Well, I'm able to compile the code and launch Kodi. I haven't tried playing anything with it. It will probably require somebody with a working knowledge of OpenMax to tell if it works.

@FernetMenta
Copy link
Contributor

anyway, it is an improvement. thanks again
jenkins build and merge

@razzeee razzeee added Type: Fix non-breaking change which fixes an issue Component: Video rendering v17 Krypton labels Dec 17, 2015
@jenkins4kodi jenkins4kodi merged commit f01a1de into xbmc:master Dec 17, 2015
@MartijnKaijser MartijnKaijser modified the milestone: K***** 17.0-alpha1 Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video rendering Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants