New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile errors in RendererOMX.cpp #8598
Conversation
@@ -27,6 +27,7 @@ | |||
#include "utils/GLUtils.h" | |||
#include "settings/MediaSettings.h" | |||
#include "windowing/WindowingFactory.h" | |||
#include "DVDCodecs/Video/DVDVideoCodecIMX.h" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
8e88793
to
0a1f3ec
Compare
I have changed the pull request to accommodate the requested changes. Please let me know if you see any other problems. |
thanks. does it work again? |
Well, I'm able to compile the code and launch Kodi. I haven't tried playing anything with it. It will probably require somebody with a working knowledge of OpenMax to tell if it works. |
anyway, it is an improvement. thanks again |
I found a few compile-time errors in RendererOMX.cpp (see 9435210), which I have tried to fix.
I'm not too sure about the changes, and hope somebody can help me review them.
The
bool CRendererOMX::Supports(ESCALINGMETHOD mode)
-method was missing, so I added it withreturn false;
, I have no idea whether this is correct.