open text files in filemanager

[ronie]

this adds the option to display the content of textfiles in the filemanager.

[BigNoid]

Nice one. From code it looks like you want xsp and m3u files to open with the textviewer too? That doesn't work on my end, it opens those as it were directories.

[ronie]

ah yeah, silly me. i'll remove those.
playlists should be opened by the player.

[msduketown]

Why is that close-button on the left?

[ronie]

usually a close button will close the dialog...
i have no reason to believe it acts differently in this case.

[msduketown]

All other dialogs have a close-button on the right...

edit: And I think centring (like #8242) would look so much better. Maybe even a candidate to reduce dialogs.xml's further.

[ronie]

[MrMC]

might want to sanity check the file size or someone is going to try and open a huge log file :)

[guidosarducci]

This is wonderful to have and feels long overdue. Pending defensive/sanity changes as noted above, my only question is if this could make it into Jarvis too?

[razzeee]

Nope, Jarvis is feature frozen.

[ronie]

updated. limited the buffer length, as suggested.

[ronie]

jenkins build this please

[Paxxi]

There's still no sanity check on the size and there should probably be some error handling and not just display an empty window. I would defer window loading and setting the header until after the file is sanity checked. This will fail on win32 log file I guess as it's using utf16 for some reason and this assumes encoding is ascii or utf8

[stefansaraev]

ready to go ?

[ronie]

judging by the comments, i'd say it's far from ready to go.
i'm afraid i have no idea how to fix those issues.

[ronie]

closing, superseded by #13093