videodb: fix smart playlists not honoring "Show empty TV shows" setting. #8824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| Filter filter2(filter); | ||
| if (!CSettings::GetInstance().GetBool(CSettings::SETTING_VIDEOLIBRARY_SHOWEMPTYTVSHOWS)) | ||
| filter2.AppendWhere("totalCount IS NOT NULL AND totalCount > 0"); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks like moving the setting check from GetTvShowsByWhere to GetTvShowsNav in PR 5752 broke smart playlists as they were previously honoring the advanced setting (hideemptyseries) and then the GUI one. Previous behavior is restored by adding additional logic in GetItems.
anaconda
force-pushed
the
5752-fix-smartplaylist
branch
from
ef513ec
to
b9ae916
Compare
|
Ping @anaconda |
|
What is the plan for this PR - I've had it in my builds for months but will drop it if there are no immediate plans to merge this now. |
|
I'd prefer it if my comment was considered. But apart from that I'm all for fixing this. |
|
@anaconda if you have some time, mind finishing this PR? Time to get our list of open PRs down a bit :) |
|
@anaconda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like moving the setting check from GetTvShowsByWhere to GetTvShowsNav in
PR 5752 broke smart playlists as they were previously honoring the advanced
setting (hideemptyseries) and then the GUI one.
Previous behavior is restored by adding additional logic in GetItems.
@Montellese Didn't feel like making
filternon-const considering this is only needed in one case out of 16, are you ok with this?