[videoinfotag] Avoid overwriting valid "default" rating with invalid data on scraper parse. #8889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaconda
changed the title
|
The fix it's ok. |
|
Up to you. |
|
It's probably better to allocate a float variable that we might not use than do an xml parse twice.. |
With online scrapers (but not with NFO files) ParseNative gets called multiple times, so avoid adding a "default" rating every time it's called. See http://forum.kodi.tv/showthread.php?tid=238393&pid=2217024#pid2217024
anaconda
force-pushed
the
8080-fix-overwrite
branch
from
441b733
to
fa583ff
Compare
|
Updated. |
phate89
added a commit
that referenced
this pull request
Jan 19, 2016
[videoinfotag] Avoid overwriting valid "default" rating with invalid data on scraper parse.
|
merged. Thanks @anaconda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With online scrapers (but not with NFO files) ParseNative gets called multiple
times, so avoid adding a "default" rating every time it's called as we may have a valid one already.
See http://forum.kodi.tv/showthread.php?tid=238393&pid=2217024#pid2217024
@phate89 your opinion?