fix crashing if music is scanning and application gets stopped #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -393,12 +393,12 @@ bool CMusicInfoScanner::IsScanning() | |||
| return m_bRunning; | |||
| } | |||
|
|
|||
| void CMusicInfoScanner::Stop() | |||
| void CMusicInfoScanner::Stop(bool wait /*= false*/) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks sane IMO. |
|
@Montellese updated |
|
jenkins build this please |
|
Maybe but it could go into a point release as well. |
|
well RC1 only to be released so that gives better testing ground than doing it in a point release imo. Up to you of course |
|
I think this is pretty safe for backport. Fix is rather straightforward. |
MartijnKaijser
added a commit
that referenced
this pull request
Jan 20, 2016
fix crashing if music is scanning and application gets stopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.