-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dlfcn-win32 include after p8-platform rename #8926
Conversation
jenkins build addons |
jenkins build addons please |
beyond my skills @opdenkamp @fetzerch @wsnipex could you follow up? |
you simply change the line i pointed to, and make it just ${CMAKE_INSTALL_PREFIX}/include. and remove the following 3 lines (the if(WIN32) bit). |
note that kodiplatform and kodi sets prefixed include paths as well. so this will make things inconsistent. in my original draft it was consistently non-prefixed include paths, but that was changed by you guys. |
IIRC I added that win32 specific include path because one of the header files that we share with kodi core couldn't handle the include path including the "platform" bit because there the header file is simply part of EDIT: Ah looks like this has been fixed differently, see https://github.com/xbmc/xbmc/blob/master/addons/library.xbmc.addon/libXBMC_addon.h#L41 |
objections if I merge this? at least it fixed current build for win32. you can still adapt cmake to whatever you prefer |
@Memphiz ping. Jenkins needs some binary addons love as the ios builder isn't doing something. |
fine with me |
sorry for that - should be fixed ... might need to kill and retrigger ... sry - on the run |
fix dlfcn-win32 include after p8-platform rename
No description provided.