Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: continue normal playback if seek fails #8928

Closed
wants to merge 2 commits into from

Conversation

FernetMenta
Copy link
Contributor

in particular useful when hitting an end of timeshift buffer

@FernetMenta FernetMenta added Type: Improvement non-breaking change which improves existing functionality v17 Krypton Component: Video labels Jan 20, 2016
@FernetMenta
Copy link
Contributor Author

jenkins build this please

@Jalle19
Copy link
Member

Jalle19 commented Jan 20, 2016

Did you get my e-mail about the GUI issue with this patch? This looks very similar so I wonder if the issue remains.

@FernetMenta
Copy link
Contributor Author

nope, at least I am not aware of it. how is gui related to this?

@Jalle19
Copy link
Member

Jalle19 commented Jan 20, 2016

When the play speed is changed here it is not reflected in the UI so the Paused popup can stay on screen and the play button doesn't change to a pause button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants