Add support for VFS addons #8966

notspiff · 2016-01-27T19:29:46Z

This is my VFS add-on work. I send the PR to see if there is interest.

Some remaining stuff;

get the datetime things into kodiplatform (see commit disabling it for now).
clean up the callbacks. note; we have to do it like this due to threading stuff - we cannot just use the normal add-on callbacks.

see the repo list at https://github.com/notspiff for some example add-ons. No guarantee many of them are in working condition, i know vfs.sacd is (in terms of the iface), as well as vfs.rar, but there's some stability issues in the latter. also quite a few are now probably void since you have removed the code from mainline.

xbmc/addons/Addon.cpp

@@ -412,6 +413,8 @@ void CAddon::BuildLibName(const cp_extension_t *extension)
      case ADDON_SERVICE:
      case ADDON_REPOSITORY:
      case ADDON_CONTEXT_ITEM:
+      case ADDON_AUDIODECODER:


FernetMenta · 2016-01-27T20:17:10Z

IMO an excellent idea. Once this is integrated we can start cleaning up vfs, i.e. PVR is the only client of LiveTV interface and can make use of this extension point.

xbmc/cores/VideoPlayer/DVDInputStreams/DVDFactoryInputStream.cpp

 #include "utils/URIUtils.h"
+#include "addons/VFSEntry.h"


garbear · 2016-05-20T05:43:33Z

@notspiff this PR was looking pretty good, what's the status? I'm happy to help if you have any TODOs left

notspiff · 2016-05-23T21:05:28Z

i haven't touched it. there were some comments, feel free to address those. i will try to find some time..

notspiff · 2016-08-19T15:06:08Z

rebased and updated. very little tested, in particular i'm not sure how well BinaryAddonCache manages the lifetime of add-ons.

example addon: https://github.com/notspiff/vfs.sacd

this is for SuperAudioCD isos. that is the reason for the last commit.

the hack commit highlights a nasty issue with current code design, which is triggered by adding this code.

garbear · 2016-08-19T15:17:38Z

thanks for the rebase. it'll probably be a few months before I pull this into my retroplayer branch, i'm focusing on getting input near flawless for the v17 release.

notspiff · 2016-08-19T15:20:17Z

Rather it goes to master. Retro carries enough /random as-is.

aug. 2016 17:17 skrev "Garrett Brown" notifications@github.com:

thanks for the rebase. it'll probably be a few months before I pull this
into my retroplayer branch, i'm focusing on getting input near flawless for
the v17 release.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8966 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFktYAkOZ8tuETGA3rkSlEZzukAbUwQ0ks5qhckigaJpZM4HNt6Q
.

garbear · 2016-08-19T15:32:30Z

Rather RetroPlayer goes to master ;)

akva2 · 2016-08-25T05:46:09Z

modernized https://github.com/notspiff/vfs.rar

added a commit that removes the internal rar support for this reason. the add-on will not work if core carries UnrarXLib.

akva2 · 2016-08-27T19:26:06Z

modernized https://github.com/notspiff/vfs.sftp

added a commit that removes the internal sftp support.

bam80 · 2016-10-25T11:40:07Z

What is left to merge it?

akva2 · 2016-10-25T11:46:07Z

(notspiff under his day-work intentity); from my POV:

not being in a feature freeze
merging the awesome work of @AlwinEsch which cleans up the whole binary add-on concept in kodi, see Add addon instance handling AlwinEsch/kodi#28
rewriting the API to use the new constructs and adding error handling and such (largely "automated" by using the new API constructs).
choosing a single add-on to focus on, preferably something that isn't new. like vfs.sftp. then remove remove the internal and have things real-world tested for a while. if all goes well, move more shit to add-ons / start adding new stuff like vfs.sacd

itouch5000 · 2017-01-06T16:21:22Z

Any news on this topic? Will this change be part of Kodi 18?

VFS can be hit very early (InitDirectoriesXXX()) and with vfs add-ons (and audio decoders) providing VFS entries, we get in a squeeze. this is not meant for inclusion as-is just highlights the issue.

notspiff · 2017-01-09T13:21:19Z

rebased.

upstream kodiplatform is not prepared yet

wsnipex · 2017-01-10T07:53:19Z

jenkins build this with addons please

notspiff · 2017-01-10T07:58:16Z

ish, sorry for bad timing. i was asked to remove the removal commits.

Paxxi · 2017-01-10T08:06:21Z

jenkins build this with addons please

Paxxi · 2017-01-10T09:49:25Z

no relevant failures in jenkins.

xbmc/ServiceManager.h

@@ -72,6 +72,7 @@ class CServiceManager
  CPlatform& GetPlatform();

  PLAYLIST::CPlayListPlayer& GetPlaylistPlayer();
+  int init_level = 0;


Jalle19 reviewed Jan 27, 2016
View reviewed changes

xbmc/addons/Addon.cpp

@@ -412,6 +413,8 @@ void CAddon::BuildLibName(const cp_extension_t *extension)

case ADDON_SERVICE:

case ADDON_REPOSITORY:

case ADDON_CONTEXT_ITEM:

case ADDON_AUDIODECODER:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

FernetMenta reviewed Jan 28, 2016
View reviewed changes

FernetMenta mentioned this pull request Mar 3, 2016

Fix stuttering on Android #9250

Merged

notspiff force-pushed the vfs_addons_draft branch from c07be51 to 682a3de Compare August 19, 2016 15:02

notspiff force-pushed the vfs_addons_draft branch from 682a3de to 31dd267 Compare August 25, 2016 05:44

notspiff force-pushed the vfs_addons_draft branch 2 times, most recently from 0015b39 to dc17ac4 Compare November 14, 2016 11:46

hack: keep a init level in service manager

b7f0f4b

VFS can be hit very early (InitDirectoriesXXX()) and with vfs add-ons (and audio decoders) providing VFS entries, we get in a squeeze. this is not meant for inclusion as-is just highlights the issue.

notspiff force-pushed the vfs_addons_draft branch from 2b7672b to 129b51a Compare January 9, 2017 13:15

notspiff added 2 commits January 9, 2017 14:45

add support for vfs add-ons

db313a1

disable mtime code for now

25c777f

upstream kodiplatform is not prepared yet

hack: add iso to filedirectory list

8d88a54

notspiff force-pushed the vfs_addons_draft branch from 129b51a to 560857d Compare January 9, 2017 13:45

Paxxi added Component: Binary add-ons Type: Feature non-breaking change which adds functionality Type: Improvement non-breaking change which improves existing functionality v18 Leia labels Jan 9, 2017

notspiff force-pushed the vfs_addons_draft branch from 560857d to 8d88a54 Compare January 10, 2017 07:56

Paxxi merged commit f9a3f81 into xbmc:master Jan 10, 2017

ksooo reviewed Jan 10, 2017

View reviewed changes

MartijnKaijser modified the milestone: L 18.0-alpha1 Jan 11, 2017

popcornmix mentioned this pull request Feb 19, 2017

FileItem: Revert treating iso as file folder #11701

Merged

9 tasks

Hedda mentioned this pull request May 5, 2017

Add frontend to host VFS Layer [$70] libretro/RetroArch#4774

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for VFS addons #8966

Add support for VFS addons #8966

notspiff commented Jan 27, 2016

This comment was marked as spam.

This comment was marked as spam.

FernetMenta commented Jan 27, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garbear commented May 20, 2016

notspiff commented May 23, 2016

notspiff commented Aug 19, 2016

garbear commented Aug 19, 2016

notspiff commented Aug 19, 2016

garbear commented Aug 19, 2016

akva2 commented Aug 25, 2016

akva2 commented Aug 27, 2016

bam80 commented Oct 25, 2016

akva2 commented Oct 25, 2016

itouch5000 commented Jan 6, 2017

notspiff commented Jan 9, 2017

wsnipex commented Jan 10, 2017

notspiff commented Jan 10, 2017

Paxxi commented Jan 10, 2017

Paxxi commented Jan 10, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Add support for VFS addons #8966

Add support for VFS addons #8966

Conversation

notspiff commented Jan 27, 2016

This comment was marked as spam.

This comment was marked as spam.

FernetMenta commented Jan 27, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garbear commented May 20, 2016

notspiff commented May 23, 2016

notspiff commented Aug 19, 2016

garbear commented Aug 19, 2016

notspiff commented Aug 19, 2016

garbear commented Aug 19, 2016

akva2 commented Aug 25, 2016

akva2 commented Aug 27, 2016

bam80 commented Oct 25, 2016

akva2 commented Oct 25, 2016

itouch5000 commented Jan 6, 2017

notspiff commented Jan 9, 2017

wsnipex commented Jan 10, 2017

notspiff commented Jan 10, 2017

Paxxi commented Jan 10, 2017

Paxxi commented Jan 10, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.