Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] refactor favourites dialog to be a window #8982

Closed
wants to merge 2 commits into from

Conversation

xhaggi
Copy link
Member

@xhaggi xhaggi commented Jan 29, 2016

This will refactor our favourite dialog to be a media window. The biggest advantage over being a dialog is that it is now part of the window history. If you start a video, music etc. favourite and back out you will end up in the favourite window not on the home screen or somewhere else. It also supports views and sorting items like all other media windows.

@razzeee @ronie @phil65 mind taking a look.

@@ -1,5 +1,7 @@
SRCS=GUIMediaWindow.cpp \
GUIViewStateFavourites.cpp \

This comment was marked as spam.

This comment was marked as spam.

@xhaggi
Copy link
Member Author

xhaggi commented Mar 13, 2016

@phil65 my changes to Estuary are only the required ones to get it to work properly. It would be nice if you could adjust the window if we decide to merge this PR.

@ronie
Copy link
Member

ronie commented Mar 13, 2016

i never use favourites myself, but i wonder if the manually sorting option (move item up/down) won't be missed.
since the favourites list contains mixed content, people may want to group items of the same content together?

@BigNoid
Copy link
Member

BigNoid commented Mar 14, 2016

As discussed on slack, -1 from me. There are many items that don't have metadata and for those there's no benefit to have them in a media window or to have those in different views. IMO favourites is not necessarily meant for playing media, we have a playlist window for that where you can order/remove/add media in different views and play it from there. In combination with an "add to playlist" context addon it can completely replace favourites for this use case.

@NedScott
Copy link
Contributor

NedScott commented Jul 9, 2016

I don't use any direct media in my favs, but I would still really like to see this included.

For example, this makes it possible to mix shorcuts to video nodes along side Kodi add-ons or Android apps (for video apps). I can have my own "Ned's movies", then "Netflix", then "Ned's music", which is not possible with video nodes.

In Confluence in the past, I would love to have had Favs be in an icon view, as opposed to a list view. I would have also loved to have had the favs window show up in the history of the windows, so that you go back to favs after you exit out of something. This is the only universal window that users can build up, which isn't skin dependent.

With such examples, is there still an objection here?

@xhaggi xhaggi closed this Jan 19, 2017
@xhaggi xhaggi deleted the gui-refactor-favourites branch January 19, 2017 10:57
@xhaggi xhaggi restored the gui-refactor-favourites branch January 19, 2017 11:00
@xhaggi xhaggi reopened this Jan 19, 2017
@Rechi
Copy link
Member

Rechi commented Aug 14, 2017

@xhaggi this needs a rebase

@xhaggi
Copy link
Member Author

xhaggi commented Aug 14, 2017

I'll close this PR for now, because some of our members do not like the favourites dialog to be a window.

@xhaggi xhaggi closed this Aug 14, 2017
@fuzzard fuzzard mentioned this pull request Oct 1, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants