Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: fix wmapro, some codecs do not consume entire packet #9104

Merged
merged 1 commit into from Feb 11, 2016

Conversation

FernetMenta
Copy link
Contributor

see title

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Audio labels Feb 11, 2016
@FernetMenta
Copy link
Contributor Author

jenkins build this please

@fritsch
Copy link
Member

fritsch commented Feb 11, 2016

@da-anda please test - this was your file :-)

Thanks much @FernetMenta

@FernetMenta
Copy link
Contributor Author

only the usual suspects failed to build

FernetMenta added a commit that referenced this pull request Feb 11, 2016
VideoPlayer: fix wmapro, some codecs do not consume entire packet
@FernetMenta FernetMenta merged commit c4a61e4 into xbmc:master Feb 11, 2016
@FernetMenta FernetMenta deleted the wmafix branch February 11, 2016 09:31
@fritsch
Copy link
Member

fritsch commented Feb 11, 2016

To add: Verified and works for me. I see it as generic enhancement for similar files.

@razzeee razzeee added this to the Krypton 17.0-alpha1 milestone Feb 11, 2016
@MartijnKaijser
Copy link
Member

something for a backport to point release or leave it like it is?

@FernetMenta
Copy link
Contributor Author

I don't think v16 is broken in regard to this.

@da-anda
Copy link
Member

da-anda commented Feb 11, 2016

tested and works fine now, thanks. Also tested on Jarvis B3 and everything is fine there as well, so no need to backport.

@MrMC
Copy link

MrMC commented May 22, 2016

Try again :)

Works for some, does not work for others, in fact most of my test cases for wmapro are still broke and they all worked without issue under Jarvis.

@MrMC
Copy link

MrMC commented May 22, 2016

@FernetMenta
Copy link
Contributor Author

thanks, I see the issue and will think about a proper solution.
(audio for this sample starts after a couple of secs)

@MrMC
Copy link

MrMC commented May 22, 2016

also check seeks, some are fine, some result in same behavior as start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Audio Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants