[PVR] Refactor: Encapsulate recording path #9105
Conversation
ksooo
added
Type: Cleanup
|
|
||
| bool IsValid() const { return m_bValid; } | ||
|
|
||
| const std::string &GetPath() const { return m_path; } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
pvr-encapsulate-recording-path
branch
from
37d1f39
to
b8483b1
Compare
|
@ksooo pick razzeee@a3fea65 |
|
thx @razzeee |
ksooo
force-pushed
the
pvr-encapsulate-recording-path
branch
from
b5e9000
to
bedc861
Compare
|
looks good after a quick look. |
|
jenkins build this please |
|
Good improvement, thanks a lot! |
ksooo
force-pushed
the
pvr-encapsulate-recording-path
branch
from
bedc861
to
6a9e8ae
Compare
ksooo
force-pushed
the
pvr-encapsulate-recording-path
branch
from
6a9e8ae
to
60c5270
Compare
|
Rebased and |
|
jenkins build this please |
[PVR] Refactor: Encapsulate recording path
[win32][fix][VS] some missing end tags after #9105
| @@ -1125,7 +1126,9 @@ bool CGUIWindowVideoBase::OnPlayMedia(int iItem, const std::string &player) | |||
| } | |||
| CLog::Log(LOGDEBUG, "%s %s", __FUNCTION__, CURL::GetRedacted(item.GetPath()).c_str()); | |||
|
|
|||
| if (StringUtils::StartsWith(item.GetPath(), "pvr://recordings/active/")) | |||
|
|
|||
| CPVRRecordingsPath path(item.GetPath()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I agree on the second comment regarding waste if resources. The false positives created by the change mentioned above is a stupid bug in the implementation of |
No functional changes, only refactoring. Put all recordings path string manipulation magic into one specialized class.
@Jalle19 @xhaggi mind taking a look
@razzeee maybe you can supply the needed VS project files update?