[confluence] [PVR] small adjustments

[Glenn-1990]

Some small fixes as in commit messages.

[MilhouseVH]

Thanks, this fixes the errors reported in #9012.

[razzeee]

@HitcherUK @phil65 @ronie

[phil65]

Code looks fine to me now.

[Hitcher]

Cant test PVR but by the looks of the code you're trying to shift the position of a label if an icon is visible but you haven't included conditions for all the icons available (ie PVR-HasTimerScheduleError.png).

[Glenn-1990]

@HitcherUK
ListItem.HasTimer returns true for all kind of timers, including ones with an error.

[Hitcher]

@Glenn-1990
Tested with PVR demo and the icon overlaps the start time label if you use a 12h clock.
Might be easier to drop the conditional labels and stick with the shorter of the 2 while shifting the icon more to the right like this -

<control type="image">
    <left>110</left>
    <top>7</top>
    <width>16</width>
    <height>16</height>
    <texture>$VAR[PVRTimerIcon]</texture>
</control>
<control type="label">
    <left>150</left>
    <top>0</top>
    <width>250</width>
    <height>30</height>
    <font>font12</font>
    <textcolor>grey2</textcolor>
    <selectedcolor>selected</selectedcolor>
    <align>right</align>
    <aligny>center</aligny>
    <label>$INFO[ListItem.Label]</label>
</control>

[Glenn-1990]

@HitcherUK I didn't introduced this shift (only changed the textures) and I'm unable to test this atm. But I'll see what I can do about it.

[Hitcher]

Maybe @ronie or @phil65 have some thoughts?

[ronie]

@HitcherUK your suggestion looks good to me.

[Glenn-1990]

@HitcherUK Can you test now? I did not use your approach as it does not look nice when not using the 12h clock (the icon seems a bit lost then).

[Hitcher]

Yeah, that works as well.

[ronie]

closing since confluence has been removed.
feel free to resubmit your changes here:
https://github.com/xbmc/skin.confluence