CGUIWindowAddonBrowser: return -1 instead of 0 from SelectAddonID() if no addons can be listed/selected #9131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f no addons can be listed/selected
Montellese
added
Type: Improvement
|
jenkins build this please |
|
Windows binary addon failure unrelated. |
Montellese
added a commit
that referenced
this pull request
Feb 16, 2016
CGUIWindowAddonBrowser: return -1 instead of 0 from SelectAddonID() if no addons can be listed/selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is from the controller input PR #8807 from @garbear and changes the implementation of
CGUIWindowAddonBrowser::SelectAddonID()to return-1instead of0if the select dialog hasn't been shown because there are no matching addons. Right now there's no way to distinguish between that case and the case where the user simply didn't select any addon and closed the dialog again.