[addons] CAddonMgr: add GetInstallableAddons() and use it in CGUIWindowAddonBrowser::SelectAddonID() #9138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montellese
added
Type: Cleanup
|
@tamland: Is this approach ok with you? jenkins build this please |
| { | ||
| // get all addons | ||
| VECADDONS installableAddons; | ||
| if (!m_database.GetRepositoryContent(installableAddons)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
otherwise it should be good:) |
…owAddonBrowser::SelectAddonID()
Montellese
force-pushed
the
addons_getinstallableaddons
branch
from
5ccdd18
to
b093d19
Compare
|
@tamland: Thanks for the review. Added the necessary lock. jenkins build this please |
Montellese
added a commit
that referenced
this pull request
Feb 16, 2016
[addons] CAddonMgr: add GetInstallableAddons() and use it in CGUIWindowAddonBrowser::SelectAddonID()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is from the controller input PR #8807 from @garbear. It moves the logic to get a list of installable addons (for a specific addon type) from
CGUIWindowAddonBrowser::SelectAddonID()intoCAddonMgr::GetInstallableAddons()because we will also need this in the input controller configuration GUI and I don't like duplicating code.