CMake Readme Fixes #9139
Merged
CMake Readme Fixes #9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,7 +88,7 @@ cmake --build . # or: nmake | |||
| ``` | |||
| cmake -G "Visual Studio 12" <KODI_SRC>/project/cmake/ | |||
| cmake --build . --config "Debug" # or: Build solution with Visual Studio | |||
| KODI_HOME=%CD% Debug/kodi.bin | |||
| set KODI_HOME="%CD%" && Debug\kodi.exe` | |||
| ``` | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…id default build type for Linux
AchimTuran
force-pushed
the
cmake_readme_fixes
branch
from
6e66af9
to
fd6f7f5
Compare
|
@AchimTuran WinSDK should be installed with VS2013, no need to install it separately |
|
about fxc we use it since migration to dx11. here is fix for it #9135 |
|
@afedchin
I like to keep the links and the information for reference. What do you think about that idea? Should I completly remove the information or should we add that to the wiki? |
|
You can keep information about SDK just as a note |
AchimTuran
force-pushed
the
cmake_readme_fixes
branch
from
0db5023
to
6b2d3d7
Compare
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my first tests with our new CMake based build system I noticed that the instructions for Windows are not entirely correct.
@fetzerch
This PR includes the fixes we discussed. Can you have a look at it?
@afedchin
Do you know since when we use fxc.exe for shader compilation? I noticed that this part is missing in the CMake build instructions.
Can you confirm that we have to install the Windows SDK for Windows 7, 8.0, 8.1 or 10 to get our build working? I think this is the best MS link for downloading the SDK's, because it shows all available downloads. Or do you have a better link?