Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Fix tests (/ static initialization order) #9146

Merged
merged 4 commits into from
Feb 21, 2016

Commits on Feb 20, 2016

  1. [SystemGlobals] Define static initialization order of CSpecialProtocol

    The destructor of RarManager uses CSpecialProtocol (a class with only
    statics). Therefore we have to make sure that CSpecialProtocol is
    destructed after RarManager. The C++ standard guarantees the order of
    con/destruction for statics only within the same compilation unit.
    fetzerch committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    cdcee34 View commit details
    Browse the repository at this point in the history
  2. [travis] Explicitly build with debug flags

    It's useful to have asserts enabled when running the test suites.
    fetzerch committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    21d1613 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65aa269 View commit details
    Browse the repository at this point in the history
  4. [tests] Remove NullLogger usage to prevent crash

    This prevents an occasionally occurring crash.
    
    Program terminated with signal SIGSEGV, Segmentation fault.
    0  0x0000000003e21700 in ?? ()
    
    Thread 2 (Thread 0x2ab2e881b940 (LWP 28679)):
    0  0x00002ab2f156a330 in std::string::_Rep::_M_destroy(std::allocator<char> const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
    1  0x0000000001079821 in CAdvancedSettings::~CAdvancedSettings() ()
    2  0x0000000001079ae9 in CAdvancedSettings::~CAdvancedSettings() ()
    3  0x00000000008b0f21 in xbmcutil::GlobalsSingleton<CAdvancedSettings>::Deleter<std::shared_ptr<CAdvancedSettings> >::~Deleter() ()
    4  0x00002ab2f1a06259 in __run_exit_handlers (status=0, listp=0x2ab2f1d886c8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true) at exit.c:82
    5  0x00002ab2f1a062a5 in __GI_exit (status=<optimized out>) at exit.c:104
    6  0x00002ab2f19ebecc in __libc_start_main (main=0x855a50 <main>, argc=2, argv=0x7ffef5ebbcf8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffef5ebbce8) at libc-start.c:321
    7  0x0000000000855984 in _start ()
    
    Thread 1 (Thread 0x2ab3006d4700 (LWP 28684)):
    0  0x0000000003e21700 in ?? ()
    1  0x0000000000e492a2 in XbmcCommons::ILogger::Log(int, char const*, ...) ()
    2  0x0000000000c507c2 in CThread::staticThread(void*) ()
    3  0x00002ab2e89cb182 in start_thread (arg=0x2ab3006d4700) at pthread_create.c:312
    4  0x00002ab2f1ac447d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
    fetzerch committed Feb 20, 2016
    Configuration menu
    Copy the full SHA
    9f6aa55 View commit details
    Browse the repository at this point in the history