[addons] label2 cleanup #9156
Merged
[addons] label2 cleanup #9156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime is not properly localized
tamland
added
Type: Fix
|
|
||
| return result; | ||
| } | ||
|
|
||
| void CGUIWindowAddonBrowser::SetItemLabel2(CFileItemPtr item) | ||
| void CGUIWindowAddonBrowser::UpdateStaus(const CFileItemPtr& item) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tamland
force-pushed
the
addon_label2_cleanup
branch
from
fe4ba40
to
33d1df2
Compare
|
thank @razzeee! jenkins build this please |
|
@tamland this breaks the 'Downloading nn%' label2. |
|
@HitcherUK 'Breaks' how and where..? |
|
Add on browser when installing an add on. Label2 should show 'Downloading nn%' but it doesn't after this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the label2 values for addon listings. It should now use the label mask from sorting as we do everywhere else.