Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabled CURL addon access / curl download speed feature / move file f… #9234

Merged
merged 1 commit into from Feb 29, 2016
Merged

enabled CURL addon access / curl download speed feature / move file f… #9234

merged 1 commit into from Feb 29, 2016

Conversation

FernetMenta
Copy link
Contributor

credits to @mapfau

@FernetMenta FernetMenta added Type: Improvement non-breaking change which improves existing functionality v17 Krypton labels Feb 28, 2016
@MilhouseVH
Copy link
Contributor

I get the following build errors with OpenELEC when trying to include this PR: http://sprunge.us/dCbW

Maybe some missing includes?

@FernetMenta
Copy link
Contributor Author

yes, I think so. thanks

@ghost
Copy link

ghost commented Feb 29, 2016

@FernetMenta: can you pls. add the modified IFileTypes.h?

@ghost
Copy link

ghost commented Feb 29, 2016

Ah, just seen: The IFile_types.h is missing at this PR.
@FernetMenta, can you pls add it? Thanks.

@FernetMenta
Copy link
Contributor Author

@mapfau done
jenkins build this please

@MilhouseVH
Copy link
Contributor

Thanks both - builds fine for me now.

FernetMenta added a commit that referenced this pull request Feb 29, 2016
@FernetMenta
Merge pull request #9234 from FernetMenta/curl
181a842 
enabled CURL addon access / curl download speed feature / move file f…
@FernetMenta FernetMenta merged commit 181a842 into xbmc:master Feb 29, 2016
@FernetMenta FernetMenta deleted the curl branch February 29, 2016 11:52
cg110
cg110 reviewed Mar 1, 2016
View reviewed changes
xbmc/filesystem/CurlFile.cpp
@@ -593,6 +593,10 @@ void CCurlFile::SetCommonOptions(CReadState* state)
if( m_contentencoding.length() > 0 )
g_curlInterface.easy_setopt(h, CURLOPT_ENCODING, m_contentencoding.c_str());

// setup Accept-Encoding if requested
if (m_acceptencoding.length() > 0)
g_curlInterface.easy_setopt(h, CURLOPT_ACCEPT_ENCODING, m_contentencoding.c_str());

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tamland tamland mentioned this pull request Mar 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@FernetMenta @MilhouseVH @fritsch @cg110 @liberty-developer @MartijnKaijser @peak3d