Skin.SelectBool() - allow skins to set header label #9317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronie
added
Type: Improvement
| @@ -112,14 +112,18 @@ static int SelectBool(const std::vector<std::string>& params) | |||
|
|
|||
| CGUIDialogSelect* pDlgSelect = (CGUIDialogSelect*)g_windowManager.GetWindow(WINDOW_DIALOG_SELECT); | |||
| pDlgSelect->Reset(); | |||
| pDlgSelect->SetHeading(CVariant{g_localizeStrings.Get(424)}); | |||
| int iHeader = atoi(params[0].c_str()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ronie
force-pushed
the
selectbool-header
branch
from
b27d9bb
to
bc13e1b
Compare
|
updated as suggested by @xhaggi jenkins build this please |
|
did you missed to adjust the required param count at https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/builtins/SkinBuiltins.cpp#L584 |
|
nope, it's there: |
|
sorry for the noise I'm on my phone :) |
ronie
added a commit
that referenced
this pull request
Mar 13, 2016
Skin.SelectBool() - allow skins to set header label
|
Forgot to say I tested it yesterday and it was all good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow skins to define the header label instead of hardcoding it in core:
Skin.SelectBool(headerlabel, setting1label|setting1name, setting2label|setting2name...)
also added a sanity check on the setting label/name pairs (prevent kodi from crashing)
as requested by @HitcherUK
@xhaggi for review