[WinRenderer] Re-factor renderer to make it more similar to others. T… #9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afedchin
added
Type: Fix
|
jenkins build this please |
|
great! |
…his should make WinRenderer more stable.
|
@FernetMenta do you have objections on BaseRenderer and RenderManager changes? |
|
@afedchin I highly welcome this change that does what was stated in the comment: // TODO: this is a Windows only thing and should go away |
|
build error is unrelated. |
afedchin
added a commit
that referenced
this pull request
Mar 13, 2016
[WinRenderer] Re-factor renderer to make it more similar to others. T…
| || pic.format == RENDER_FMT_AML | ||
| || pic.format == RENDER_FMT_IMXMAP | ||
| || pic.format == RENDER_FMT_MMAL | ||
| || m_pRenderer->IsPictureHW(pic)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…his should make WinRenderer more stable.
@FernetMenta ping.