Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPlayer - cleanup #9454

Merged
merged 8 commits into from Mar 28, 2016
Merged

VideoPlayer - cleanup #9454

merged 8 commits into from Mar 28, 2016

Conversation

FernetMenta
Copy link
Contributor

Round1 cherry picks from #9442

@FernetMenta FernetMenta added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v17 Krypton Component: Video labels Mar 26, 2016
@FernetMenta
Copy link
Contributor Author

thanks to @MaxKellermann
I will pick more but need to finish some other work before

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

@MaxKellermann any idea why build failed on every platform but Linux?

@MaxKellermann
Copy link
Contributor

No - http://jenkins.kodi.tv/job/BuildMulti-PR/4745/ gives me "404 Not Found".

@anaconda
Copy link
Contributor

jenkins build this please

1 similar comment
@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

oops :)

@MaxKellermann
Copy link
Contributor 

/Applications/Xcode6.1.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/cstdlib:98:9: error: no member named 'div_t' in the global namespace; did you mean 'dev_t'?

This very much looks like broken libc++ headers. My include cleanup patch may have exposed this bug. Does the build server use the latest libc++ version?

@FernetMenta
Copy link
Contributor Author

I don't know but it fails on my Mac too. That has latest XCode installed.

@MaxKellermann
Copy link
Contributor

Same problem on Android, with an outdated NDK. Broken system headers.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta FernetMenta merged commit b7aa348 into xbmc:master Mar 28, 2016
@FernetMenta FernetMenta deleted the kellermann branch March 28, 2016 20:50
@MaxKellermann MaxKellermann mentioned this pull request Mar 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Video Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FernetMenta @MaxKellermann @anaconda @MartijnKaijser