-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[binary addons] a few cmake fixes #9582
Conversation
…entries in the list
…of semicolon) separated string
Thanks! Tested on Linux and I was able to build two addons after having cleared cmake/addons/addons. |
Did you bootstrap the addon repo? I am pretty sure it has to do with that as it worked fine before when we still had the addon definitions in kodi src |
@wsnipex: This is a case that never worked (at least for me). The problem is that we run cmake to generate the buildsystem on the The case where there are multiple addon definitions available but you only build one and then later on another one should still work (and works fine for me on win32). |
@Montellese can we merge this? |
jenkins build and merge |
Based on the comments in 068aafc I tried the binary addons buildsystem again and found some oddities. The first two commits are actual fixes and the other two are cosmetics.
I've only tested this on win32.