Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL-Loader whitelist instead blacklist until sandboxing is an topic #9619

Merged
merged 1 commit into from
Apr 17, 2016
Merged

DLL-Loader whitelist instead blacklist until sandboxing is an topic #9619

merged 1 commit into from
Apr 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2016

see title...

Voyager1
Voyager1 reviewed Apr 13, 2016
View reviewed changes
xbmc/cores/DllLoader/Win32DllLoader.cpp
@@ -324,6 +324,9 @@ void Win32DllLoader::OverrideImports(const std::string &dll)

bool Win32DllLoader::NeedsHooking(const char *dllName)
{
if (!StringUtils::EndsWithNoCase(dllName, "libdvdread.dll"))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ghost
Copy link
Author

ghost commented Apr 15, 2016

I have changed the dll names with the two @Voyager1 mentioned in his initial comment
Shouldn't we give it a try? I'm friend of the idea making it transparent in the kodi forum so users can look especially for issues regarding this?

afedchin
afedchin reviewed Apr 15, 2016
View reviewed changes
xbmc/cores/DllLoader/Win32DllLoader.cpp
@@ -324,6 +324,10 @@ void Win32DllLoader::OverrideImports(const std::string &dll)

bool Win32DllLoader::NeedsHooking(const char *dllName)
{
if (!(StringUtils::EndsWithNoCase(dllName, "libdvdcss-2.dll")
|| StringUtils::EndsWithNoCase(dllName, "libdvdnav.dll"))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@afedchin
Copy link
Member

as I said before this breaks addons which are working with zip:// at least the vizualization.milkdrop unable to read its presets which are packed into zip.

@ghost
Copy link
Author

ghost commented Apr 15, 2016

@afedchin where can I find the sources of this addon(??)?

@afedchin
Copy link
Member

@mapfau https://github.com/afedchin/visualization.milkdrop

@ghost
Copy link
Author

ghost commented Apr 15, 2016

@afedchin this part:

https://github.com/afedchin/visualization.milkdrop/blob/master/src/XmlDocument.cpp#L69

??

@akva2
Copy link
Contributor

akva2 commented Apr 15, 2016

@mapfau see notspiff/visualization.milkdrop top of master branch. i've drafted the necessary changes.

@ghost
Copy link
Author

ghost commented Apr 15, 2016 •
edited by ghost

ahhhh, this is so great! thanx @akva2

Edit: @akva2 have you already give it a try (I mean your changes)?
@afedchin Are you fine with the changes from @akva2 ?

@ghost ghost changed the title DLLOader whitelist instead blacklist until sandboxing is an topic DLL-Loader whitelist instead blacklist until sandboxing is an topic Apr 15, 2016
@FernetMenta FernetMenta added Type: Improvement non-breaking change which improves existing functionality v17 Krypton labels Apr 15, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-alpha1 milestone Apr 15, 2016
@ghost
Copy link
Author

ghost commented Apr 15, 2016 •
edited by ghost

Following the link to an information post for developers:

http://forum.kodi.tv/showthread.php?tid=269661

Feel free to move it into any section in the forum you think its better placed.
I have limited access to e.g. announcement sections....

@FernetMenta
Copy link
Contributor

jenkins build this please

@akva2
Copy link
Contributor

akva2 commented Apr 15, 2016

no, draft means draft. I dont do windows unless you pay me.

@fritsch
Copy link
Member

fritsch commented Apr 15, 2016

:-)

2016-04-15 19:13 GMT+02:00 Arne Morten Kvarving notifications@github.com:

no, draft means draft. I dont do windows unless you pay me.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9619 (comment)

               Key-ID:     0x1A995A9B
               keyserver: pgp.mit.edu

Fingerprint: 4606 DA19 EC2E 9A0B 0157 C81B DA07 CF63 1A99 5A9B

@ghost
Copy link
Author

ghost commented Apr 16, 2016 •
edited by ghost

@afedchin : do you want to continue the change? Or should I support the rewriting?
If I support, I need some advide in what this addon is for and how to get it run.

Edit: I have pushed an PR

@FernetMenta
Copy link
Contributor

I no objections I will merge this this evening.

@FernetMenta FernetMenta merged commit 237007b into xbmc:master Apr 17, 2016
@ghost ghost deleted the whitelist_dllloader branch April 18, 2016 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@afedchin @akva2 @FernetMenta @fritsch @Montellese @Voyager1 @Paxxi @notspiff @peak3d