Stop scanning directory if scan is cancelled. #9620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't look complete. If you just exit the loop, it will proceed with cleaning/compression the db below. |
tamland
added
Type: Improvement
|
Hi, |
|
@tamland mind having a look again? |
|
@tgagneret Can you please format according to Code guidelines and squash down to one commit? Logic-wise it should be good. |
If the list of paths are remote directories which are unreachables, it won't enter the DoScan function (because the directories will be seen as non-existent) and it continues the scan of the directories. So we allow the possibility to exit the directory scan loop at each iteration.
tgagneret
force-pushed
the
fix/videoScanning_stop
branch
from
5c95b39
to
9f5e93d
Compare
|
@tamland Done |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the list of paths are remote directories which are unreachable it won't enter the DoScan function (because the directories will be seen as non-existent) and it continues the scan of the directories. So we allow the possibility to exit the directory scan loop at each iteration.
For example if there is 10 remote directories and we are stopping the scan after 6, it would avoid to have 4 connections timeout before exiting the loop.