Better handling of mis-matching musicbrianz album artist id and hints tags #9625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTBlake
added
Type: Fix
|
|
||
| // Vector of possible separators in the order least likely to be part of artist name | ||
| const char *sepinit[] = { " feat. ", ";", ":", "|", "#", "/", ",", "&" }; | ||
| std::vector<std::string> separators(sepinit, std::end(sepinit)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thanks @phate89 for the code suggestions. My dev env is in pieces at the moment, attempting to back out of VS2015 (seems incompatible with my old PC) which has brought me to a halt. |
DaveTBlake
force-pushed
the
FixArtistTagRobust
branch
from
ee042b5
to
9c3fb76
Compare
| return results; | ||
|
|
||
| for (const auto& item : input) | ||
| results.push_back(item); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…t Ids and (Album) Artist tags when creating songs and albums. Fix missing hints (ALBUMARTISTS tag) causing artist hints to be used to get album artist to match mbid rather than try album artist itself. Made mess when artist hints are broken and repair happening.
DaveTBlake
force-pushed
the
FixArtistTagRobust
branch
from
9c3fb76
to
9b37330
Compare
|
Thanks for the improvements @phate89 jenkins build this please |
|
Compile error not related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow on from #8904 with more improved handling of mis-matching numbers of Musicbrainz (Album) Artist Ids and (Album) Artist tags when creating songs and albums.
Primarily this was to fix an issue where missing hints (ALBUMARTISTS tag) was causing the album artist tag to be ignored (even when matched mbid) and artist hints and names to be used instead to get album artist names to match the number of mbid. If there was a mis-match of artist names and mbid then the results were quite confusing.
For example:
ARTIST = "artist1 feat. artist2"
MUSICBRAINZ ARTISTID = mbid1
MUSICBRAINZ ARTISTID = mbid2
ALBUMARTIST = "artist1"
MUSICBRAINZ ALBUMARTISTID = mbid1
resulted in an artist named "artist1 feat. artist2" with mbid1 for the album even though the number of album artist names and mbids matched, and the lack of ARTISTS tag and mis-match of mbid <-> name count would have been repaired for the song.
Also a user managed to have ARTISTS and ALBUMARTISTS tags present but as single string with an unexpected separator. If one user can do it so can others, so a more flexible approach to parsing both (ALBUM)ARTIST and (ALBUM)ARTISTS tags when the number of names does not match the number of Musicbrainz ids seems worthwhile.
Hence when an inconsistency in the number of artist names to mbid occurrs this applies improved parsing to both hints and names, using multiple item separators progressively, in an attempt to correctly interpret the way music files have been tagged.
@razzeee got some time to look at this? The sooner it is out there getting more real user data through it the better