Haptics and Controller power-off #9663

garbear · 2016-04-22T05:45:14Z

This PR activates controller rumble motors when the user receives a notification. Also, thanks to Montellese, we have the ability to power off controllers on exit.

Two settings are added:

"Test rumble"
"Power off controllers on exit"

This PR currently relies on the retroplayer branch of peripheral.joystick. These changes will be merged to master when this PR is merged.

ATM, rumble and power-off-on-exit are only supported via the XInput API on windows. Additional APIs can be added at a later date independent of Kodi.

xbmc/peripherals/addons/AddonInputHandling.cpp

@@ -39,15 +42,25 @@ CAddonInputHandling::CAddonInputHandling(CPeripheral* peripheral, IInputHandler*
  {
    m_buttonMap.reset(new CAddonButtonMap(peripheral, addon, handler->ControllerID()));
    if (m_buttonMap->Load())
-      m_driverHandler.reset(new CInputHandling(handler, m_buttonMap.get()));
-    else
-      m_buttonMap.reset();


Montellese · 2016-04-22T07:16:33Z

BTW the Android API supports vibration patterns, see http://developer.android.com/reference/android/os/Vibrator.html. Maybe that might be something that would be useful for other stuff as well? I don't really know how libretro provides rumble events though.

Hedda · 2016-04-22T07:44:22Z

Will haptics (rumble) have GUI options to be disabled and enabled? Maybe even have GUI settings to enable or disable rumble for different things? I know that at least I would not want to have rumble enabled for notifications by default but I would like to have it enabled in games by default.

Montellese · 2016-04-22T20:32:22Z

@garbear is there a branch in peripheral.joystick with just the rumble stuff in it? I wanted to update my "turn off controller on shutdown" work and thought it best to do it on top of this work but I also need to update peripheral.joystick.

Montellese · 2016-04-22T21:46:35Z

nvm I pulled together the necessary commits, squashed them as good as possible and added mine on top, see https://github.com/Montellese/peripheral.joystick/commits/joystick_poweroff in case you are interested in the squashed commits. And https://github.com/Montellese/xbmc/commits/joystick_shutdown has my commits on top of this PR.

garbear · 2016-04-22T22:40:15Z

@Hedda I'm wary of settings creep, but I can see your point, it might be annoying if all 4 controllers rumble every time a notification is shown. What if we drop the commit and only rumble in games? I added rumble on notifications as more of a proof of concept anyway.

@Montellese you're right, the rumble command should go somewhere else in case multiple notifications are queued. Thanks for the power off support, should I tack that on and make this a dual-feature PR?

Montellese · 2016-04-23T07:53:51Z

You can include it here or I can provide it as a separate PR once this has gone in, I don't really care.

garbear · 2016-04-23T18:45:56Z

OK, I'll save you the trouble and add it here.

So what's the consensus? Do we drop rumble-on-notification for now? Once rumble functionality is in it'll be trivial to add it later. Also, rumble can be made less annoying by shortening the duration or lowering the intensity (motors support values from 0.0 to 1.0)

Montellese · 2016-04-23T19:14:59Z

I'd either make the rumble on notifications configurable or remove it completely.

xbmc/peripherals/addons/PeripheralAddon.cpp

+      {
+        CPeripheralJoystick* joystick = static_cast<CPeripheralJoystick*>(peripheral.second);
+        if (joystick->SupportsPowerOff())
+          PowerOffJoystick(joystick->RequestedPort());


garbear · 2016-04-23T20:32:33Z

I'll add a setting. The input page in system settings is getting a little crowded, but this is fixed in my RetroPlayer work - all controller settings are moved to a "game input" page

addons/resource.language.en_gb/resources/strings.po

@@ -15568,7 +15568,19 @@ msgctxt "#35050"
 msgid "Controller profiles"
 msgstr ""

-#empty strings from id 35051 to 35054
+#. Setting to test rumble


garbear · 2016-07-03T18:16:34Z

jenkins build this please (to test if I rebased on alpha 2 properly)

MartijnKaijser · 2016-08-05T08:35:57Z

@garbear nudge

garbear · 2016-08-05T17:39:40Z

The major thing stopping this was a crash if you disconnected the controller shortly after connecting it. My wireless 360 controller had low batteries, and when it connected Kodi told it to rumble and the rumble drew too much power and killed the controller and crashed Kodi :)

Fixing this will require a bit of refactoring. I rebased this patch on master last night, I'll try to look into the crash soon.

MartijnKaijser · 2016-08-06T17:36:12Z

@garbear well v16 crashed when even a controller was connected.
Also you can now drop the visual Studio files as windows now uses cmake

… it on shutdown (configurable)

garbear · 2016-08-06T19:59:01Z

Rebased on master. I'll look into the crash

…nnected

garbear · 2016-08-08T22:36:36Z

Fixed the crash. jenkins build this please

garbear · 2016-08-09T20:39:35Z

@MartijnKaijser ok to merge?

nille02 · 2016-10-13T20:55:52Z

Is there a way to disable the rumble? its horrible for each notification. The Pad lies on a table and its extreme loud when it rumbles on max speed

Montellese reviewed Apr 22, 2016
View reviewed changes

Montellese added Type: Feature non-breaking change which adds functionality v17 Krypton Component: Input labels Apr 22, 2016

garbear force-pushed the rumble branch from dcf7068 to 1ca1ca1 Compare April 23, 2016 19:06

garbear changed the title ~~Haptics~~ Haptics and Controller power-off Apr 23, 2016

garbear force-pushed the rumble branch 2 times, most recently from f38d1b7 to 6ca89b4 Compare April 23, 2016 19:32

garbear reviewed Apr 23, 2016
View reviewed changes

xbmc/peripherals/addons/PeripheralAddon.cpp

{

CPeripheralJoystick* joystick = static_cast<CPeripheralJoystick*>(peripheral.second);

if (joystick->SupportsPowerOff())

PowerOffJoystick(joystick->RequestedPort());

This comment was marked as spam.

Sign in to view

garbear force-pushed the rumble branch from 6ca89b4 to c4a1625 Compare April 23, 2016 20:13

da-anda reviewed Apr 24, 2016
View reviewed changes

addons/resource.language.en_gb/resources/strings.po

@@ -15568,7 +15568,19 @@ msgctxt "#35050"

msgid "Controller profiles"

msgstr ""

#empty strings from id 35051 to 35054

#. Setting to test rumble

This comment was marked as spam.

Sign in to view

garbear force-pushed the rumble branch from c4a1625 to 8fa7851 Compare July 3, 2016 18:15

garbear mentioned this pull request Jul 20, 2016

[rbp] [retroplayer] Add zero copy mmal support to retroplayer garbear/xbmc#62

Merged

garbear added 2 commits August 6, 2016 12:55

[controllers] use "category" for element name and add haptics

3c295e1

[peripheral API] v1.0.18 - Add rumble capability

c181965

garbear and others added 5 commits August 6, 2016 12:55

[peripheral API] Move primitives vector to stack

b35e72e

[joysticks] Add "Test rumble" setting

df6dd94

[joysticks] Add rumble on Kai Toast notification

4bcb48b

[Peripheral API] v1.0.19 - Add PowerOffJoystick() API method

a9444f2

[joysticks] automatically power off peripheral joysticks that support…

27d6fcc

… it on shutdown (configurable)

garbear force-pushed the rumble branch from 8fa7851 to 27d6fcc Compare August 6, 2016 19:58

[joysticks] Fix freeze when controller is rapidly connected and disco…

727801a

…nnected

MartijnKaijser merged commit 27c22fe into xbmc:master Aug 10, 2016

MartijnKaijser added this to the Krypton 17.0-beta1 milestone Aug 10, 2016

garbear mentioned this pull request Aug 10, 2016

Rumble and controller power off xbmc/peripheral.joystick#43

Merged

garbear deleted the rumble branch August 13, 2016 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Haptics and Controller power-off #9663

Haptics and Controller power-off #9663

garbear commented Apr 22, 2016 •

edited

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Montellese commented Apr 22, 2016

Hedda commented Apr 22, 2016

Montellese commented Apr 22, 2016

Montellese commented Apr 22, 2016

garbear commented Apr 22, 2016

Montellese commented Apr 23, 2016

garbear commented Apr 23, 2016 •

edited

Montellese commented Apr 23, 2016

This comment was marked as spam.

garbear commented Apr 23, 2016

This comment was marked as spam.

garbear commented Jul 3, 2016

MartijnKaijser commented Aug 5, 2016

garbear commented Aug 5, 2016

MartijnKaijser commented Aug 6, 2016

garbear commented Aug 6, 2016

garbear commented Aug 8, 2016

garbear commented Aug 9, 2016

nille02 commented Oct 13, 2016 •

edited

Haptics and Controller power-off #9663

Haptics and Controller power-off #9663

Conversation

garbear commented Apr 22, 2016 • edited

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Montellese commented Apr 22, 2016

Hedda commented Apr 22, 2016

Montellese commented Apr 22, 2016

Montellese commented Apr 22, 2016

garbear commented Apr 22, 2016

Montellese commented Apr 23, 2016

garbear commented Apr 23, 2016 • edited

Montellese commented Apr 23, 2016

This comment was marked as spam.

garbear commented Apr 23, 2016

This comment was marked as spam.

garbear commented Jul 3, 2016

MartijnKaijser commented Aug 5, 2016

garbear commented Aug 5, 2016

MartijnKaijser commented Aug 6, 2016

garbear commented Aug 6, 2016

garbear commented Aug 8, 2016

garbear commented Aug 9, 2016

nille02 commented Oct 13, 2016 • edited

garbear commented Apr 22, 2016 •

edited

garbear commented Apr 23, 2016 •

edited

nille02 commented Oct 13, 2016 •

edited