[GUI] add orientation support to slider controls #9704
Conversation
ronie
added
Type: Feature
| @@ -1517,7 +1519,8 @@ namespace XBMCAddon | |||
| #ifndef SWIG | |||
| std::string strTextureBack; | |||
| std::string strTexture; | |||
| std::string strTextureFoc; | |||
| std::string strTextureFoc; | |||
| int iOrientation; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ronie |
Is it not possible to use existing skin code? If not would it be possible to set the slide as vertical if the orientation tag is missing? |
| @@ -533,12 +533,14 @@ namespace XBMCAddon | |||
| ControlSlider::ControlSlider(long x, long y, long width, long height, | |||
| const char* textureback, | |||
| const char* texture, | |||
| const char* texturefocus) | |||
| const char* texturefocus, | |||
| long orientation) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Except the things what @tamland mentioned I can't see any issues. Many thanks for the patch, can't wait to see it in our master branch. I guess Rjsachse will be very happy about this. |
ronie
force-pushed
the
slider-orientation
branch
2 times, most recently
from
18a2a23
to
8fb1cab
Compare
|
Wouldn't a skinner just need to change the default.xml so it don't break the rest of the skin. Should not be a huge deal breaker since krypton has so many changes. |
correct, it's exactly 1 line of code skinners need to add to defaults.xml |
|
@tamland updated the python implementation. |
| * | ||
| * x : integer - x coordinate of control.\n | ||
| * y : integer - y coordinate of control.\n | ||
| * width : integer - width of control.\n | ||
| * height : integer - height of control.\n | ||
| * textureback : [opt] string - image filename.\n | ||
| * texture : [opt] string - image filename.\n | ||
| * texturefocus : [opt] string - image filename.n" | ||
| * texturefocus : [opt] string - image filename.\n | ||
| * orientation : [opt] integer - orientation of slider (0=horizontal / 1=vertical(default)). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tamland thx! i need a bit of hand holding now and then :-) jenkins build this please |
|
squashed & added skin needed changes |
|
yeah, if it builds:) |
|
jenkins build this please |
allow skins to create a vertical slider, as requested on the forum:
http://forum.kodi.tv/showthread.php?tid=218756&pid=2318996#pid2318996
ping @AchimTuran
@tamland i tried to add it to the xbmcgui.ControlSlider() class as well for python addons,
but i'm pretty uncomfortable messing in this code area, please review.
*note this will mess up existing sliders as the default orientation defined globally in kodi is vertical.
skins/addons will need to adopt.