[adsp] remove usage of list item entries on skins #9708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phil65 @roni @AchimTuran can check them. |
|
nice, skin changes are ok. |
AlwinEsch
force-pushed
the
improve-adsp-part
branch
from
725c21a
to
4d5a718
Compare
AlwinEsch
added
Type: Improvement
|
Nice, thx for goin after my request that fast. :) |
| CFileItemPtr item(new CFileItem()); | ||
| item->SetLabel(g_localizeStrings.Get(dsp_mode_types[i].iName)); | ||
| item->SetLabel2(g_localizeStrings.Get(dsp_mode_types[i].iDescription)); | ||
| item->SetProperty("currentMode", dsp_mode_types[i].sModeType); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I guess something similiar like |
|
Already a pull request on confluence: xbmc/skin.confluence#9 :D If I'm not wrong, works it also if the set is still is still in xml and the values from Kodi becomes overwritten. |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the set of list entries on skin itself and do this on code side.
Further becomes with this way only the Mode type shown who is present.
Here screenshots about the changes
