Refresh controller profiles in gui thread (and 2 small improvements) #9824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
force-pushed
the
fix-controllers-refresh
branch
from
9276f11
to
4fa904f
Compare
garbear
changed the title
|
PR has been updated. There was a problem where the refresh msg was lost, so that's been fixed. I also added 2 small improvements: some code cleanup, and a UX improvement. I noticed that in the controller dialog, the user had to press Select twice to start a button prompt: Once to focus the button, and once to begin the prompting wizard. This change combines the two actions, so selecting the controller will focus the button and automatically start the prompt. |
garbear
force-pushed
the
fix-controllers-refresh
branch
from
09e3b7a
to
ff72fc1
Compare
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Notify() callback can arrive from any thread, so move the refresh call to the GUI thread.