Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on helper: add foreign buildsystem support #9829

Merged
merged 2 commits into from
Jun 1, 2016

Conversation

notspiff
Copy link
Contributor

Allow taking advantage of foreign buildsystems. Make the CMake target copy a binary built by the external project. This is used for libretro-based add-ons where the add-on binary is not specific to Kodi.

This has been sitting in retroplayer for a few years. I have extended it with support for a custom data directory. It's split so @garbear doesn't have to deal with a conflict.

list(GET ${prefix}_CUSTOM_BINARY 0 FROM_BINARY)
list(GET ${prefix}_CUSTOM_BINARY 1 TO_BINARY)
if(OS STREQUAL "android")
set(TO_BINARY "lib${TO_BINARY}")

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@fetzerch
Copy link
Member

fetzerch commented May 17, 2016

+1 for the change, verified couple of times that it works with libretro cores.
Just since you anyways touch those lines: mind changing the commands to lowercase? (if/else/install, ...)

@hudokkow
Copy link
Member

Don't bother changing to lowercase. I have a branch with that done.
Although not perfect, this helps. Rest is grep and s/old/new/

@fetzerch
Copy link
Member

Ok, otherwise good to go?

jenkins build this with addons please

@hudokkow
Copy link
Member

👍
Build is fine. The usual suspects fail on Linux and peripheral.joystick didn't liked the includes change but I'm waiting on garbear's input.

Needs a rebase.

Allow taking advantage of foreign buildsystems. Make the CMake target copy a binary built by the external project.

This is used for libretro-based add-ons where the add-on binary is not specific to Kodi.
@notspiff
Copy link
Contributor Author

rebased.

@hudokkow
Copy link
Member

Thanks!
jenkins build this with addons please

@hudokkow hudokkow added Type: Improvement non-breaking change which improves existing functionality v17 Krypton CMake labels May 23, 2016
@hudokkow hudokkow added this to the Krypton 17.0-alpha2 milestone Jun 1, 2016
@hudokkow hudokkow merged commit 9420a41 into xbmc:master Jun 1, 2016
@hudokkow
Copy link
Member

hudokkow commented Jun 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants