-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on helper: add foreign buildsystem support #9829
Conversation
list(GET ${prefix}_CUSTOM_BINARY 0 FROM_BINARY) | ||
list(GET ${prefix}_CUSTOM_BINARY 1 TO_BINARY) | ||
if(OS STREQUAL "android") | ||
set(TO_BINARY "lib${TO_BINARY}") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
+1 for the change, verified couple of times that it works with libretro cores. |
Don't bother changing to lowercase. I have a branch with that done. |
Ok, otherwise good to go? jenkins build this with addons please |
👍 Needs a rebase. |
Allow taking advantage of foreign buildsystems. Make the CMake target copy a binary built by the external project. This is used for libretro-based add-ons where the add-on binary is not specific to Kodi.
76d4426
to
5006667
Compare
rebased. |
Thanks! |
Thanks! |
Allow taking advantage of foreign buildsystems. Make the CMake target copy a binary built by the external project. This is used for libretro-based add-ons where the add-on binary is not specific to Kodi.
This has been sitting in retroplayer for a few years. I have extended it with support for a custom data directory. It's split so @garbear doesn't have to deal with a conflict.