Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Cosmetics: change commands to lowercase #9833

Merged
merged 5 commits into from
Jun 1, 2016

Conversation

hudokkow
Copy link
Member

Cosmetics only and low priority.
Script used to automate it can be found here. Might be useful for others.

@fetzerch, @wsnipex for review

@hudokkow hudokkow added Type: Improvement non-breaking change which improves existing functionality v17 Krypton CMake labels May 18, 2016
@fetzerch
Copy link
Member

Personally I'm quite in favor of strict rules. One thing that would additionally make sense:
if("${OS}") is simply if(OS).

For the files that are only used in the main CMake build system, I'd say: go for it. (there's not much git history anyway). For the binary addon buildsystem it still has my +1, even though I see a small disadvantage of git blame being a bit more difficult to use.

@fetzerch
Copy link
Member

One more thing might be to replace "if( " and " )" with "if(" and ")"?

@hudokkow hudokkow force-pushed the cmake_code_style branch 4 times, most recently from f194455 to 20bc6de Compare May 24, 2016 14:06
@hudokkow hudokkow force-pushed the cmake_code_style branch 2 times, most recently from 596c409 to 2757d6b Compare May 30, 2016 21:36
@hudokkow
Copy link
Member Author

If no one objects, this is going in tomorrow.
jenkins build this with addons please

@hudokkow hudokkow force-pushed the cmake_code_style branch 2 times, most recently from e05f44d to f4ea751 Compare May 31, 2016 21:39
@hudokkow hudokkow merged commit 86d651c into xbmc:master Jun 1, 2016
@hudokkow hudokkow deleted the cmake_code_style branch June 1, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants