Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Feature: Make instant recording behavior configurable #9847

Merged
merged 4 commits into from
Jun 1, 2016

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented May 20, 2016

This feature has been requested in at least two different forum threads.

Currently, when pressing the "record" button in Live TV OSD, on the remote control or on keyboard a fixed length recording starting "now", ending after the time set as "Instant timer duration" setting value will be scheduled.

People want more flexibility here, especially the possibility to let instant recording record the currently playing show.

This PR implements configurable instant recording behavior.

First, there is a new settings value in PVR->Recording, "Instant recordig action":

screenshot000

Three values are available:

screenshot001

  • [Record current show] will record the current show from "now" to the end of the show. If no TV guide data is currently available a fixed length recording starting "now", with the value set for "Instant recording duration" will be scheduled.
  • [Record for a fixed period of time] will schedule a fixed length recording starting "now", with the value set for "Instant recording duration".
  • [Ask what to do] will open a dialogue containing different recording actions to choose from, like "Record current show", "Record next show" and some fixed duration recordings.

The first two options will immediately start recording without any user interaction, the third option will open a dialog with a couple of choices:

screenshot003

The options currently implemented for the dialog as well as the wording are only a suggestion and can easily be changed.

@da-anda we discussed this on last Devcon
@Jalle19, @xhaggi mind taking a look at the code

@ksooo ksooo added Type: Feature non-breaking change which adds functionality Component: PVR v17 Krypton labels May 20, 2016
@ksooo ksooo force-pushed the pvr-improve-instant-timer branch from 089c008 to e3bdd75 Compare May 20, 2016 20:27
#. Label for "Instant recording action" dialog settings value
#: xbmc/pvr/PVRMananger.cpp
msgctxt "#19092"
msgid "Record next show (%s)"

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@ksooo ksooo force-pushed the pvr-improve-instant-timer branch 4 times, most recently from 6c2c329 to eb30cb3 Compare May 29, 2016 09:51
@ksooo ksooo force-pushed the pvr-improve-instant-timer branch 2 times, most recently from 8599517 to 4c0869f Compare May 30, 2016 20:20
@ksooo
Copy link
Member Author

ksooo commented May 31, 2016

If nobody objects I will merge this tomorrow.

{
enum PVRRECORD_INSTANTRECORDACTION
{
PVRRECORD_INSTANTRECORDACTION_NONE = -1,

This comment was marked as spam.

This comment was marked as spam.

@Jalle19
Copy link
Member

Jalle19 commented May 31, 2016

Sorry for the late review, nothing critical found though.

@ksooo
Copy link
Member Author

ksooo commented May 31, 2016

Thanks @Jalle19. I thought you already did a review.

@Jalle19
Copy link
Member

Jalle19 commented May 31, 2016

Only did it half way the first time :-P

@ksooo ksooo force-pushed the pvr-improve-instant-timer branch from 7ac5664 to ac5193e Compare May 31, 2016 11:19
@ksooo
Copy link
Member Author

ksooo commented May 31, 2016

jenkins build this please

@ksooo
Copy link
Member Author

ksooo commented Jun 1, 2016

Changes requested by @Jalle19 are in.
Rebased.
Jenkins is happy.

@ksooo ksooo merged commit ecea559 into xbmc:master Jun 1, 2016
@ksooo ksooo deleted the pvr-improve-instant-timer branch June 1, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Feature non-breaking change which adds functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants