-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR] Feature: Make instant recording behavior configurable #9847
Conversation
089c008
to
e3bdd75
Compare
#. Label for "Instant recording action" dialog settings value | ||
#: xbmc/pvr/PVRMananger.cpp | ||
msgctxt "#19092" | ||
msgid "Record next show (%s)" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
6c2c329
to
eb30cb3
Compare
…hannel): Record current show if avail, otherwise create instant timer
8599517
to
4c0869f
Compare
If nobody objects I will merge this tomorrow. |
{ | ||
enum PVRRECORD_INSTANTRECORDACTION | ||
{ | ||
PVRRECORD_INSTANTRECORDACTION_NONE = -1, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sorry for the late review, nothing critical found though. |
Thanks @Jalle19. I thought you already did a review. |
Only did it half way the first time :-P |
7ac5664
to
ac5193e
Compare
jenkins build this please |
Changes requested by @Jalle19 are in. |
This feature has been requested in at least two different forum threads.
Currently, when pressing the "record" button in Live TV OSD, on the remote control or on keyboard a fixed length recording starting "now", ending after the time set as "Instant timer duration" setting value will be scheduled.
People want more flexibility here, especially the possibility to let instant recording record the currently playing show.
This PR implements configurable instant recording behavior.
First, there is a new settings value in PVR->Recording, "Instant recordig action":
Three values are available:
The first two options will immediately start recording without any user interaction, the third option will open a dialog with a couple of choices:
The options currently implemented for the dialog as well as the wording are only a suggestion and can easily be changed.
@da-anda we discussed this on last Devcon
@Jalle19, @xhaggi mind taking a look at the code