VideoPlayerVideo: Need to clear pictures before switching decoder #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @FernetMenta |
| @@ -179,8 +179,11 @@ void CVideoPlayerVideo::OpenStream(CDVDStreamInfo &hint, CDVDVideoCodec* codec) | |||
| m_fForcedAspectRatio = 0.0; | |||
|
|
|||
| if (m_pVideoCodec) | |||
| { | |||
| m_pVideoCodec->ClearPicture(&m_picture); | |||
| m_pVideoCodec->Dispose(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@FernetMenta updated |
| @@ -99,6 +99,8 @@ CVideoPlayerVideo::CVideoPlayerVideo(CDVDClock* pClock | |||
|
|
|||
| CVideoPlayerVideo::~CVideoPlayerVideo() | |||
| { | |||
| if (m_pVideoCodec) | |||
| m_pVideoCodec->Dispose(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Codecs already call this from their destructors
The new decoder may not know how clear a picture initialised from a different decoder. For example MMALCodec wants Release() called on clear, but VideoCodecFFMPEG does not.
|
@FernetMenta updated |
|
+1, thanks |
FernetMenta
added
Type: Fix
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new decoder may not know how clear a picture initialised from a different decoder.
For example MMALCodec wants Release() called on clear, but VideoCodecFFMPEG does not.