Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginDirectory - avoid BusyDialog if not called by main thread #9862

Merged
merged 1 commit into from May 23, 2016

Conversation

FernetMenta
Copy link
Contributor

follow up from #9778

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue Component: GUI engine Component: Add-ons labels May 22, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-alpha2 milestone May 22, 2016
@Montellese
Copy link
Member

Ideally there shouldn't be any GUI related code in the VFS part (no dialogs or display related stuff like the "All albums" nodes etc.). That logic should be part of CGUIMediaWindow or any of its derived classes. But obviously that's a major task and out of scope for this fix.

CScriptObserver scriptObs(scriptId, m_fetchComplete);
if (!CGUIDialogBusy::WaitOnEvent(m_fetchComplete, 200))
// kill the script if it does not return within 10 seconds
if (!m_fetchComplete.WaitMSec(10000))

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@FernetMenta
Copy link
Contributor Author

updated
jenkins build this please

@FernetMenta
Copy link
Contributor Author

Android build failure unrelated

@FernetMenta FernetMenta merged commit 44b2d8f into xbmc:master May 23, 2016
@FernetMenta FernetMenta deleted the plugin branch May 23, 2016 09:58
@BmdOnline
Copy link

Hi,
like I said in kodi forum (http://forum.kodi.tv/showthread.php?tid=269814&pid=2345031#pid2345031), some plugins aren't working since Milhouse 0522 build.

For example, with Youtube 5.2.1 plugin, I have this message in kodi.log

23:09:36 12917.675781 T:1962225664 ERROR: GetDirectory - Error getting plugin://plugin.video.youtube/channel/UCMkOKU7usWmqcpLDcWG9PtQ/
23:09:36 12917.719727 T:1962225664 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.youtube/channel/UCMkOKU7usWmqcpLDcWG9PtQ/) failed

And, with SuprFavourites 1.0.43 plugin, I have same kind of error :

23:12:00 13061.955078 T:1962225664 ERROR: GetDirectory - Error getting plugin://plugin.program.super.favourites/?fanart=%2Fstorage%2F.kodi%2Faddons%2Fplugin.program.super.favourites%2Ffanart.j​pg&image=DefaultFolder.png&label=Explore%20Kodi%20favourites&mode=300
23:12:00 13061.968750 T:1962225664 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.program.super.favourites/?fanart=%2Fstorage%2F.kodi%2Faddons%2Fplugin.program.super.favourites%2Ffanart.j​pg&image=DefaultFolder.png&label=Explore%20Kodi%20favourites&mode=300) failed

Everything is OK with 0421 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Add-ons Component: GUI engine Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants