configure.ac:Changing android ndk directory existence test #9873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting ndk 11 ndk_dir/RELEASE.TXT was removed. The new file to test is ndk_dir/source.properties according to a proposal at http://forum.kodi.tv/showthread.php?tid=274621&pid=2337598#pid2337598 for the ability to configure the build for both prior and post 11 ndk version, changing the test for any of the mentioned files above (“or” between both of them).
|
jenkins build this please |
|
nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting ndk 11 ndk_dir/RELEASE.TXT was removed.
The new file to test is ndk_dir/source.properties according to a proposal at
http://forum.kodi.tv/showthread.php?tid=274621&pid=2337598#pid2337598
for the ability to configure the build for both prior and post 11 ndk version, changing the test for any of the mentioned files above (“or” between both of them).
Actually as seen in the actual change below the test is "&&"
If both of them are absent, then the test fails.
If one of them is present then it passes this sanity check.