Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Make CMake aware of textfiles that configure the build #9876

Merged
merged 1 commit into from Jun 1, 2016

Conversation

Projects
None yet
3 participants
@fetzerch
Copy link
Member

commented May 24, 2016

The CMake based buildsystem is based on reading the input of textfiles at configure-time. As CMake does not track files that are just accessed using "file(READ)" building does not automatically retrigger a reconfiguration when those files are changes. This commit fixes it with the CMAKE_CONFIGURE_DEPENDS variable.

This should remove the necessity to manually rerun CMake when files are changed during development. (Due to globbing in some places, CMake still has to be rerun when textfiles are added or removed!)

pings: @hudokkow, @wsnipex, @notspiff
Not sure if I covered all cases though. Please also let me know if you've seen other cases, where a manual reconfigure was necessary.

@akva2

This comment has been minimized.

Copy link
Contributor

commented May 26, 2016

Lets kill the glob for text files

[cmake] Make CMake aware of textfiles that configure the build
The CMake based buildsystem is based on reading the input of textfiles
at configure-time. As CMake does not track files that are just accessed
using "file(READ)" building does not automatically retrigger a
reconfiguration when those files are changes. This commit fixes it by
either using configure_file or using the CMAKE_CONFIGURE_DEPENDS
variable.

This should remove the necessity to manually rerun CMake when files are
changed during development. (Due to globbing CMake still has to be
rerun when files are added or removed!)

@fetzerch fetzerch force-pushed the fetzerch:cmake_textfiles branch from 8228a4d to ee443bb Jun 1, 2016

@fetzerch

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2016

Yes, definitively!

jenkins build this with addons please

@fetzerch fetzerch merged commit 8803a66 into xbmc:master Jun 1, 2016

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
default Merged build finished.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@fetzerch fetzerch deleted the fetzerch:cmake_textfiles branch Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.