[cmake] Make CMake aware of textfiles that configure the build #9876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetzerch
added
Type: Improvement
|
Lets kill the glob for text files |
The CMake based buildsystem is based on reading the input of textfiles at configure-time. As CMake does not track files that are just accessed using "file(READ)" building does not automatically retrigger a reconfiguration when those files are changes. This commit fixes it by either using configure_file or using the CMAKE_CONFIGURE_DEPENDS variable. This should remove the necessity to manually rerun CMake when files are changed during development. (Due to globbing CMake still has to be rerun when files are added or removed!)
|
Yes, definitively! jenkins build this with addons please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake based buildsystem is based on reading the input of textfiles at configure-time. As CMake does not track files that are just accessed using "file(READ)" building does not automatically retrigger a reconfiguration when those files are changes. This commit fixes it with the CMAKE_CONFIGURE_DEPENDS variable.
This should remove the necessity to manually rerun CMake when files are changed during development. (Due to globbing in some places, CMake still has to be rerun when textfiles are added or removed!)
pings: @hudokkow, @wsnipex, @notspiff
Not sure if I covered all cases though. Please also let me know if you've seen other cases, where a manual reconfigure was necessary.