[cmake] get rid of ManageString.cmake #9878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudokkow
added
Type: Cleanup
|
Very much +1, I've seen this already some time ago, but was busy with something else. |
|
Yeah, I stumbled into it looking at something completely different. |
hudokkow
force-pushed
the
cmake_managestring
branch
4 times, most recently
from
9567028
to
a4d0108
Compare
Only one of the provided macros is used (STRING_SPLIT) and only in one place and we can achieve the same with a simple string(REPLACE ...
hudokkow
force-pushed
the
cmake_managestring
branch
from
a4d0108
to
2302fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one of the provided macros is used (STRING_SPLIT) and only
in one place and we can achieve the same with a simple string(REPLACE ...
@wsnipex, @fetzerch