[xbmc][cleanup][win32] Silence some warnings and some minor cleanup #9962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved most initialization to the declaration as it's easier to spot missed members that way when there's so many member variables. There's still a few missing initialization but I'm not sure what's a sane default so leaving them as is.
Paxxi
added
Type: Cleanup
|
@afedchin review please and maybe you can fill in the missing initialization? |
| m_inScene = false; | ||
| m_needNewDevice = false; | ||
| m_resizeInProgress = false; | ||
| m_screenHeight = 0; | ||
| m_systemFreq = CurrentHostFrequency(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
looks good, thanks. |
|
jenkins build and merge this please |
|
jenkins build and merge this please? |
|
jenkins build and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved most initialization to the declaration as it's easier to spot missed members that way when there's so many member variables. There's still a few missing initialization but I'm not sure what's a sane default so leaving them as is.