Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbmc][cleanup][win32] Silence some warnings and some minor cleanup #9962

Merged
merged 3 commits into from
Jun 13, 2016

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Jun 12, 2016

Moved most initialization to the declaration as it's easier to spot missed members that way when there's so many member variables. There's still a few missing initialization but I'm not sure what's a sane default so leaving them as is.

Moved most initialization to the declaration as it's easier to spot missed members that way when there's so many member variables. There's still a few missing initialization but I'm not sure what's a sane default so leaving them as is.
@Paxxi Paxxi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Windows labels Jun 12, 2016
@Paxxi
Copy link
Member Author

Paxxi commented Jun 12, 2016

@afedchin review please and maybe you can fill in the missing initialization?

m_inScene = false;
m_needNewDevice = false;
m_resizeInProgress = false;
m_screenHeight = 0;
m_systemFreq = CurrentHostFrequency();

This comment was marked as spam.

@afedchin
Copy link
Member

looks good, thanks.

@Paxxi
Copy link
Member Author

Paxxi commented Jun 13, 2016

jenkins build and merge this please

@Paxxi
Copy link
Member Author

Paxxi commented Jun 13, 2016

jenkins build and merge this please?

@FernetMenta
Copy link
Contributor

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 95949e5 into xbmc:master Jun 13, 2016
@Paxxi Paxxi deleted the warnings branch March 11, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Windows Type: Cleanup non-breaking change which removes non-working or unmaintained functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants